Skip to content

Add failure_reason tag to activity execution failed metrics #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmaeagle99 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Add failure_reason tag to activity execution failed metrics #3036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/internal/activity/ActivityTaskHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,17 @@ static ActivityTaskHandler.Result mapToActivityFailure(
metricsScope.tagged(
ImmutableMap.of(MetricsTag.EXCEPTION, exception.getClass().getSimpleName()));
if (!FailureUtils.isBenignApplicationFailure(exception)) {
// The deprecated counter keeps its original tags so that dashboards still reading it are
// not split into a new series.
Scope failureScope =
ms.tagged(
ImmutableMap.of(
MetricsTag.TASK_FAILURE_TYPE, MetricsTag.TASK_FAILURE_VALUE_ACTIVITY_ERROR));
if (isLocalActivity) {
ms.counter(MetricsType.LOCAL_ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
failureScope.counter(MetricsType.LOCAL_ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
ms.counter(MetricsType.LOCAL_ACTIVITY_FAILED_COUNTER).inc(1);
} else {
ms.counter(MetricsType.ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
failureScope.counter(MetricsType.ACTIVITY_EXEC_FAILED_COUNTER).inc(1);
}
}
Failure failure = dataConverter.exceptionToFailure(exception);
Expand Down
1 change: 1 addition & 0 deletions temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ private Map<String, String> getActivityTagsWithWorkerType(
tags.put("namespace", "UnitTest");
tags.put("activity_type", "Execute");
tags.put("exception", "ApplicationFailure");
tags.put("failure_reason", "ActivityError");
tags.put("worker_type", workerType);
tags.put("workflow_type", workflowType);
return tags;
Expand Down
1 change: 1 addition & 0 deletions temporal-sdk/src/test/java/io/temporal/workflow/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ public void testTemporalActivityFailureMetric() throws InterruptedException {
.putAll(TAGS_ACTIVITY_WORKER)
.put(MetricsTag.ACTIVITY_TYPE, "ThrowIO")
.put(MetricsTag.EXCEPTION, "IOException")
.put(MetricsTag.TASK_FAILURE_TYPE, MetricsTag.TASK_FAILURE_VALUE_ACTIVITY_ERROR)
.put(MetricsTag.WORKFLOW_TYPE, "NoArgsWorkflow")
.build();

Expand Down
1 change: 1 addition & 0 deletions temporal-serviceclient/src/main/java/io/temporal/serviceclient/MetricsTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class MetricsTag {
public static final String TASK_FAILURE_VALUE_NON_DETERMINISM_ERROR = "NonDeterminismError";
public static final String TASK_FAILURE_VALUE_GRPC_MESSAGE_TOO_LARGE = "GrpcMessageTooLarge";
public static final String TASK_FAILURE_VALUE_WORKFLOW_ERROR = "WorkflowError";
public static final String TASK_FAILURE_VALUE_ACTIVITY_ERROR = "ActivityError";
public static final String TASK_FAILURE_VALUE_OPERATION_FAILED = "operation_failed";
public static final String TASK_FAILURE_VALUE_OPERATION_CANCELED = "operation_canceled";
public static final String TASK_FAILURE_VALUE_HANDLER_ERROR_BAD_REQUEST =
Expand Down
Loading