Log slow workflow task completion diagnostics#2946
Open
Debashismitra01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added diagnostics logging for slow Workflow Task completion.
The worker now emits
TMPRL1104logs when Workflow Task processing takes longer than the configured thresholds:The log includes external payload storage statistics:
Implementation changes:
WorkflowTaskPayloadStatsfor collecting payload operation metricsWorkflowTaskPayloadStatsContextfor tracking stats during Workflow Task executionCodecDataConverterWorkflowWorkerWhy?
External payload storage operations can increase Workflow Task completion time because payloads may need to be uploaded to or downloaded from external storage.
When this latency causes Workflow Tasks to approach their timeout, users need visibility into whether payload storage operations are contributing to the delay.
These diagnostics make slow Workflow Task completion easier to investigate.
Checklist
Closes SDK should log when WFT completion takes a long time - Java #2883
How was this tested:
Added and updated unit tests:
WorkflowWorkerTestTMPRL1104CodecDataConverterTestWorkflowTaskPayloadStatsTestRan:
./gradlew :temporal-sdk:test --tests io.temporal.internal.worker.WorkflowWorkerTest ./gradlew :temporal-sdk:test --tests io.temporal.common.converter.CodecDataConverterTest ./gradlew :temporal-sdk:test --tests io.temporal.internal.worker.WorkflowTaskPayloadStatsTest ./gradlew spotlessCheck 3.Any docs updates needed? No docs updates needed. This only adds internal diagnostics logging.