Add ChildWorkflowOptions support to WorkflowImplementationOptions (#2)#2887
Open
porunov wants to merge 1 commit into
Open
Add ChildWorkflowOptions support to WorkflowImplementationOptions (#2)#2887porunov wants to merge 1 commit into
porunov wants to merge 1 commit into
Conversation
|
|
…plementationOptions Fixes temporalio#2790 - Add childWorkflowOptions map and defaultChildWorkflowOptions fields - Add setChildWorkflowOptions() and setDefaultChildWorkflowOptions() builder methods - Add getChildWorkflowOptions() and getDefaultChildWorkflowOptions() getters - Update SyncWorkflowContext to store and expose child workflow options - Update WorkflowInternal.newChildWorkflowStub() to merge predefined options - Add mergeChildWorkflowOptions() method to ChildWorkflowOptions.Builder - Add integration and unit tests --------- Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
bd8e2d9 to
3295d53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2790
Tests are added to:
ChildWorkflowOptionsInWorkflowImplementationOptionsTest.javaPotential documentation place: https://docs.temporal.io/develop/java/workflows/child-workflows (it could be something similar as activity options documentation).
Disclaimer: Code was Generated by Opus 4.6 in Copilot. Reviewed manually.