Narrow cli.Dockerfile's workers COPY to what's actually needed#386
Open
lilydoar wants to merge 1 commit into
Open
Narrow cli.Dockerfile's workers COPY to what's actually needed#386lilydoar wants to merge 1 commit into
lilydoar wants to merge 1 commit into
Conversation
The CLI image copied the entire workers/ tree (all language worker sources) but only needs workers/proto (for the kitchen-sink-gen protoc build) and workers/go/harness/api (the go.mod replace target for the ./cmd/omes build). Copy just those two, trimming the build context and making the dependency explicit. Verified by building the CLI image with podman. stack-info: PR: #386, branch: lilydoar/stack/18
a74f980 to
5d455a3
Compare
d5b5fcb to
36d64ac
Compare
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Narrow cli.Dockerfile's workers COPY to what's actually needed
The CLI image copied the entire workers/ tree (all language worker sources)
but only needs workers/proto (for the kitchen-sink-gen protoc build) and
workers/go/harness/api (the go.mod replace target for the ./cmd/omes build).
Copy just those two, trimming the build context and making the dependency
explicit. Verified by building the CLI image with podman.