Move devserver to internal/devserver#374
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
devserver (the embedded Temporal dev-server launcher) has no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. Move it and update the two importers. Testing: `go build ./...` passes; the internal/devserver unit tests (TestAllocatePorts, TestDefaultOutputDirUsesRepoRoot, TestWriteDynamicConfig, ...) pass. stack-info: PR: #374, branch: lilydoar/stack/8
lilydoar
force-pushed
the
lilydoar/stack/7
branch
from
f3a4afe to
3b08fcc
Compare
lilydoar
force-pushed
the
lilydoar/stack/8
branch
from
d7c2e41 to
0f87a97
Compare
This was referenced May 28, 2026
stephanos
requested changes
May 29, 2026
Collaborator
There was a problem hiding this comment.
Oh, but the idea is that temporalio/temporal#10413 will leverage the devserver
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Move devserver to internal/devserver
devserver (the embedded Temporal dev-server launcher) has no consumer outside
the root module. Application code that isn't part of a public API belongs
under internal/, where the import boundary is compiler-enforced. Move it and
update the two importers.
Testing:
go build ./...passes; the internal/devserver unit tests(TestAllocatePorts, TestDefaultOutputDirUsesRepoRoot, TestWriteDynamicConfig,
...) pass.