Skip to content

[CLDIAM-651] Remove versioning from custom role methods #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shakeelrao merged 4 commits into from
Apr 9, 2026
+0 −17
Merged

[CLDIAM-651] Remove versioning from custom role methods #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a33b353
[CLDIAM-651] Remove versioning from custom role methods
asmclean Apr 9, 2026
bd88506
Remove version from request and response messages
asmclean Apr 9, 2026
2ba09e6
Revert to v0.13.0
asmclean Apr 9, 2026
2734eb9
Remove from message and spec
asmclean Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions temporal/api/cloud/cloudservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,6 @@ message GetBillingReportResponse {
temporal.api.cloud.billing.v1.BillingReport billing_report = 1;
}

// temporal:versioning:min_version=v0.13.0
message GetCustomRolesRequest {
// The requested size of the page to retrieve.
// Cannot exceed 1000. Defaults to 100.
Expand All @@ -1104,27 +1103,23 @@ message GetCustomRolesRequest {
string page_token = 2;
}

// temporal:versioning:min_version=v0.13.0
message GetCustomRolesResponse {
// The list of custom roles in ascending ID order.
repeated temporal.api.cloud.identity.v1.CustomRole custom_roles = 1;
// The next page token.
string next_page_token = 2;
}

// temporal:versioning:min_version=v0.13.0
message GetCustomRoleRequest {
// The ID of the custom role to retrieve.
string role_id = 1;
}

// temporal:versioning:min_version=v0.13.0
message GetCustomRoleResponse {
// The custom role retrieved.
temporal.api.cloud.identity.v1.CustomRole custom_role = 1;
}

// temporal:versioning:min_version=v0.13.0
message CreateCustomRoleRequest {
// The specification for the custom role to create.
temporal.api.cloud.identity.v1.CustomRoleSpec spec = 1;
Expand All @@ -1133,15 +1128,13 @@ message CreateCustomRoleRequest {
string async_operation_id = 2;
}

// temporal:versioning:min_version=v0.13.0
message CreateCustomRoleResponse {
// The ID of the custom role created.
string role_id = 1;
// The async operation.
temporal.api.cloud.operation.v1.AsyncOperation async_operation = 2;
}

// temporal:versioning:min_version=v0.13.0
message UpdateCustomRoleRequest {
// The ID of the custom role to update.
string role_id = 1;
Expand All @@ -1155,13 +1148,11 @@ message UpdateCustomRoleRequest {
string async_operation_id = 4;
}

// temporal:versioning:min_version=v0.13.0
message UpdateCustomRoleResponse {
// The async operation.
temporal.api.cloud.operation.v1.AsyncOperation async_operation = 1;
}

// temporal:versioning:min_version=v0.13.0
message DeleteCustomRoleRequest {
// The ID of the custom role to delete.
string role_id = 1;
Expand All @@ -1173,7 +1164,6 @@ message DeleteCustomRoleRequest {
string async_operation_id = 3;
}

// temporal:versioning:min_version=v0.13.0
message DeleteCustomRoleResponse {
// The async operation.
temporal.api.cloud.operation.v1.AsyncOperation async_operation = 1;
Expand Down
5 changes: 0 additions & 5 deletions temporal/api/cloud/cloudservice/v1/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,6 @@ service CloudService {
}

// Get custom roles
// temporal:versioning:min_version=v0.13.0
rpc GetCustomRoles(GetCustomRolesRequest) returns (GetCustomRolesResponse) {
option (google.api.http) = {
get: "/cloud/custom-roles"
Expand All @@ -1177,7 +1176,6 @@ service CloudService {
}

// Get a custom role
// temporal:versioning:min_version=v0.13.0
rpc GetCustomRole(GetCustomRoleRequest) returns (GetCustomRoleResponse) {
option (google.api.http) = {
get: "/cloud/custom-roles/{role_id}"
Expand All @@ -1194,7 +1192,6 @@ service CloudService {
}

// Create a custom role
// temporal:versioning:min_version=v0.13.0
rpc CreateCustomRole(CreateCustomRoleRequest) returns (CreateCustomRoleResponse) {
option (google.api.http) = {
post: "/cloud/custom-roles"
Expand All @@ -1212,7 +1209,6 @@ service CloudService {
}

// Update a custom role
// temporal:versioning:min_version=v0.13.0
rpc UpdateCustomRole(UpdateCustomRoleRequest) returns (UpdateCustomRoleResponse) {
option (google.api.http) = {
post: "/cloud/custom-roles/{role_id}"
Expand All @@ -1230,7 +1226,6 @@ service CloudService {
}

// Delete a custom role
// temporal:versioning:min_version=v0.13.0
rpc DeleteCustomRole(DeleteCustomRoleRequest) returns (DeleteCustomRoleResponse) {
option (google.api.http) = {
delete: "/cloud/custom-roles/{role_id}"
Expand Down
2 changes: 0 additions & 2 deletions temporal/api/cloud/identity/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ message ApiKeySpec {
bool disabled = 6;
}

// temporal:versioning:min_version=v0.13.0
message CustomRoleSpec {
// The name of the custom role.
string name = 1;
Expand All @@ -329,7 +328,6 @@ message CustomRoleSpec {
}
}

// temporal:versioning:min_version=v0.13.0
message CustomRole {
// The id of the custom role.
string id = 1;
Expand Down
Loading