feat: add temporal options command and declutter help output#1061
Draft
chaptersix wants to merge 1 commit into
Draft
feat: add temporal options command and declutter help output#1061chaptersix wants to merge 1 commit into
chaptersix wants to merge 1 commit into
Conversation
Hide global and connection flags from help output, replacing them with a hint to the new `temporal options` command. This follows the kubectl pattern where `kubectl options` lists global flags. Changes: - Add `temporal options` command with grouped tables for global and connection options, showing flag, env var, config key, and description - Hide root persistent flags from root help output - Hide client option flags from subcommand help via `hide-from-help` option set attribute and generated `HideFlags()` methods - Add `implied-env` and `config-key` annotations to generated flag descriptions so env vars and config keys are discoverable - Add `Description()` methods to option sets, driven from YAML - Shorten option descriptions to remove info now shown in table columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temporal optionscommand (kubectl-style) that displays global and connection flags in a table with env var and config key columns--helpand connection flags from subcommand--help, replacing them with a hint totemporal optionshide-from-help,config-key, andDescription()support to the option set YAML spec and code generatorBefore
After
Test plan
go build ./cmd/temporalgo test ./internal/temporalcli/ -run TestHelptemporal --helpno longer shows global flagstemporal workflow --helpno longer shows connection flagstemporal workflow list --helpshows only command-specific flagstemporal optionsdisplays both tables with correct env/config columns