Skip to content

Add Notification Service WIT definition #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VegetarianOrc merged 3 commits into from
Oct 13, 2026
Merged

Add Notification Service WIT definition #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aef442
Add notificaiton service wit
VegetarianOrc Sep 15, 2026
e872859
Rename interface in notification-service.wit
VegetarianOrc Oct 12, 2026
c9bab08
Validate notification WIT with system Nexus generation
VegetarianOrc Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ PROTO_PATHS = paths=source_relative:$(PROTO_OUT)
OAPI_OUT := openapi
OAPI3_PATH := .components.schemas.Payload

NEX_GEN ?= nex-gen
NEX_GEN ?= nexgen

$(PROTO_OUT):
mkdir $(PROTO_OUT)
Expand Down Expand Up @@ -144,20 +144,29 @@ nexus-rpc-yaml-install:
##### Compile system Nexus WIT files #####
system-nexus-wit: system-nexus-wit-install nex-gen-install
printf $(COLOR) "Generate system Nexus WIT..."
protoc -I $(PROTO_ROOT) \
tmp=$$(mktemp -d); trap 'rm -rf "$$tmp"' EXIT; \
protoc -I $(PROTO_ROOT) --include_imports \
--descriptor_set_out="$$tmp/system.bin" \
--system-nexus-wit_opt=output=nexus/workflow-service.wit \
--system-nexus-wit_opt=nex_gen=$(NEX_GEN) \
--system-nexus-wit_opt=linked_input=nexus/deps \
--system-nexus-wit_out=. \
temporal/api/workflowservice/v1/service.proto
temporal/api/workflowservice/v1/service.proto \
temporal/api/notificationservice/v1/request_response.proto && \
$(NEX_GEN) add-message \
--descriptors "$$tmp/system.bin" \
--file temporal/api/notificationservice/v1/request_response.proto \
--input nexus/notification-service.wit \
--input nexus/deps \
--output nexus/notification-service.wit

system-nexus-wit-install:
printf $(COLOR) "Build and install protoc-gen-system-nexus-wit..."
@cd cmd/protoc-gen-system-nexus-wit && go install .

nex-gen-install:
printf $(COLOR) "Install nex-gen if missing..."
command -v $(NEX_GEN) >/dev/null || cargo install nex-gen --version ^0.1
printf $(COLOR) "Install nexgen if missing..."
command -v $(NEX_GEN) >/dev/null || cargo install nexgen --version ^0.2 --features advanced

##### Clean #####
clean:
Expand Down
34 changes: 34 additions & 0 deletions nexus/notification-service.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package temporal:nexus@1.0.0;

world system {
export notification-service;
}

interface notification-service {
use nexus:temporal-types/model@1.0.0.{
failure,
placeholder,
};

/// @nexus.type-parameter
type source-context-t = placeholder;

/// @nexus.type-parameter
type output-t = placeholder;

/// @nexus.proto "temporal.api.notificationservice.v1.OnCompleteRequest.result"
variant on-complete-request-result {
success(output-t),
failure(failure),
}

/// @nexus.proto "temporal.api.notificationservice.v1.OnCompleteRequest"
record on-complete-request {
%result: on-complete-request-result,
source-context: source-context-t,
}

/// @nexus.proto "temporal.api.notificationservice.v1.OnCompleteResponse"
record on-complete-response {
}
}
Loading