Repository navigation
vts: add time skipping to schedules - #856
Merged
Merged
Conversation
feiyang3cat
force-pushed
the
fx/vts-scheduler
branch
2 times, most recently
from
September 19, 2026 00:13
b616bd7 to
1d2710e
Compare
feiyang3cat
marked this pull request as ready for review
September 20, 2026 23:34
5 tasks done
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
fx/vts-scheduler
branch
from
October 9, 2026 02:32
1d2710e to
46b1b80
Compare
feiyang3cat
commented
Oct 9, 2026
|
|
||
| // Timestamps of schedule creation and last update. | ||
| google.protobuf.Timestamp create_time = 6; | ||
| google.protobuf.Timestamp update_time = 7; |
Member
Author
There was a problem hiding this comment.
for reviewers:
the update_time will be come virtual time when time skipping enabled
from schedule's perspective, is it better to change it back to real time or not? do we need to provide both time ?
feiyang3cat
commented
Oct 9, 2026
feiyang3cat
commented
Oct 12, 2026
feiyang3cat
commented
Oct 12, 2026
feiyang3cat
commented
Oct 12, 2026
| // passed by right now, all at once. The overlap policy can be overridden for the | ||
| // scope of the backfill. | ||
| repeated BackfillRequest backfill_request = 2; | ||
|
|
Member
Author
There was a problem hiding this comment.
add time skipping config
chaptersix
reviewed
Oct 12, 2026
| option csharp_namespace = "Temporalio.Api.Schedule.V1"; | ||
|
|
||
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/field_mask.proto"; |
Contributor
There was a problem hiding this comment.
hmm.. I've not seen this before. It looks like it has precedent across the repo. What's it's intent?
GregoryTravis
approved these changes
Oct 13, 2026
feiyang3cat
force-pushed
the
fx/vts-scheduler
branch
from
October 14, 2026 06:00
23c7253 to
1428c7a
Compare
feiyang3cat
force-pushed
the
fx/vts-scheduler
branch
from
October 14, 2026 06:47
1428c7a to
dafbb85
Compare
chaptersix
approved these changes
Oct 14, 2026
davidporter-id-au
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
related server API temporalio/temporal#12197