Skip to content

Add TASK_QUEUE_KIND_WORKER_COMMANDS for worker-commands task queues#763

Open
rkannan82 wants to merge 3 commits intomasterfrom
kannan/worker-commands-kind
Open

Add TASK_QUEUE_KIND_WORKER_COMMANDS for worker-commands task queues#763
rkannan82 wants to merge 3 commits intomasterfrom
kannan/worker-commands-kind

Conversation

@rkannan82
Copy link
Copy Markdown
Contributor

@rkannan82 rkannan82 commented Apr 10, 2026

What

Add TASK_QUEUE_KIND_WORKER_COMMANDS (value 3) to TaskQueueKind enum.

Why

Worker-commands task queues are used for server-to-worker communication (e.g. activity cancellations). They need to be distinguished from user-defined queues so the server can handle them differently in metrics and other areas. SDKs will set this kind when polling worker-commands queues.

How did you test it?

Proto-only change, no runtime behavior yet.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 requested review from a team April 10, 2026 00:24
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 changed the title Add TASK_QUEUE_KIND_INTERNAL for server-internal task queues Add TASK_QUEUE_KIND_WORKER_COMMANDS for worker-commands task queues Apr 10, 2026
@rkannan82 rkannan82 requested a review from Sushisource April 10, 2026 00:34
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a bigger server side design discussion before we add new kinds. That has lots of implications. We need to look at all the different types of ephemeral queues we want to support and figure out what properties are needed in what combinations.

@ShahabT
Copy link
Copy Markdown
Contributor

ShahabT commented Apr 10, 2026

@dnr what you're saying makes sense, but I don't know why adding this WORKER_COMMANDS kind should be blocked by it. we know already that we want to do some custom things about this particular kind of task queues in server so better to pass the info in a clean and formal way rather than string prefix checks.

@dnr
Copy link
Copy Markdown
Contributor

dnr commented Apr 10, 2026

Sure, but we should think about the scope of this new kind. E.g. could we/should we use the same kind for other ephemeral queue types

@rkannan82
Copy link
Copy Markdown
Contributor Author

Sure, but we should think about the scope of this new kind. E.g. could we/should we use the same kind for other ephemeral queue types

Proposed server implementation:

@rkannan82 rkannan82 requested a review from dnr April 10, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants