Add TASK_QUEUE_KIND_WORKER_COMMANDS for worker-commands task queues#763
Add TASK_QUEUE_KIND_WORKER_COMMANDS for worker-commands task queues#763
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dnr
left a comment
There was a problem hiding this comment.
We need a bigger server side design discussion before we add new kinds. That has lots of implications. We need to look at all the different types of ephemeral queues we want to support and figure out what properties are needed in what combinations.
|
@dnr what you're saying makes sense, but I don't know why adding this WORKER_COMMANDS kind should be blocked by it. we know already that we want to do some custom things about this particular kind of task queues in server so better to pass the info in a clean and formal way rather than string prefix checks. |
|
Sure, but we should think about the scope of this new kind. E.g. could we/should we use the same kind for other ephemeral queue types |
Proposed server implementation:
|
What
Add
TASK_QUEUE_KIND_WORKER_COMMANDS(value 3) toTaskQueueKindenum.Why
Worker-commands task queues are used for server-to-worker communication (e.g. activity cancellations). They need to be distinguished from user-defined queues so the server can handle them differently in metrics and other areas. SDKs will set this kind when polling worker-commands queues.
How did you test it?
Proto-only change, no runtime behavior yet.
🤖 Generated with Claude Code