Skip to content

fix(console): discrepancy between interactive and static single choice result #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 1 commit into from
Mar 23, 2026
+9 −3
Merged

fix(console): discrepancy between interactive and static single choice result #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/console/src/Components/Static/StaticSingleChoiceComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ public function render(Console $console): null|int|UnitEnum|string
return true;
}

if (! $this->options->isList() && $answer === (string) $option->key) {
return true;
}

if ($this->options->getOptions()->isList() && $answer === (string) $index) {
return true;
}
Expand All @@ -75,7 +79,9 @@ public function render(Console $console): null|int|UnitEnum|string
});

if ($selectedOption !== null) {
return $selectedOption->value;
return $this->options->isList()
? $selectedOption->value
: $selectedOption->key;
}

return $this->render($console);
Expand Down
4 changes: 2 additions & 2 deletions tests/Integration/Console/Components/Static/StaticSingleChoiceComponentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function test_assoc_submit_key(): void
$console->writeln("picked {$answer}");
})
->submit(1)
->assertContains('picked B');
->assertContains('picked b');
}

public function test_assoc_submit_value(): void
Expand All @@ -73,7 +73,7 @@ public function test_assoc_submit_value(): void
$console->writeln("picked {$answer}");
})
->submit('B')
->assertContains('picked B');
->assertContains('picked b');
}

public function test_enum_submit_value(): void
Expand Down
Loading