fix(database): relations joins overshadowing if property name conflict in chain#2064
Open
laylatichy wants to merge 9 commits intotempestphp:3.xfrom
Open
fix(database): relations joins overshadowing if property name conflict in chain#2064laylatichy wants to merge 9 commits intotempestphp:3.xfrom
laylatichy wants to merge 9 commits intotempestphp:3.xfrom
Conversation
f882200 to
b62b6fc
Compare
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit 46de25e |
b62b6fc to
b883d97
Compare
b883d97 to
2ea0c63
Compare
99b2b17 to
69f4473
Compare
69f4473 to
46de25e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in a case the parent model has the same property name as child model one is overshadowed leading to invalid query
Given models like this:
User::select()->with('role', 'role.permissions', 'permissions')->all();
would lead to user.role.permissions being overshadowed by user.permissions and dropped