fix(database): fix is relation loaded and correctly unset properties#2063
Open
laylatichy wants to merge 8 commits intotempestphp:3.xfrom
Open
fix(database): fix is relation loaded and correctly unset properties#2063laylatichy wants to merge 8 commits intotempestphp:3.xfrom
laylatichy wants to merge 8 commits intotempestphp:3.xfrom
Conversation
e2b3028 to
4e5c183
Compare
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit e733691 |
201e271 to
235a93c
Compare
235a93c to
a208259
Compare
a208259 to
177b33c
Compare
177b33c to
680c0fa
Compare
Contributor
Author
|
@brendt some fixes so isRelationLoaded works correctly but, it might have breaking behavior, kinda I guess if somebody relied on broken behavior in his app to work now class Author {
public ?Publisher $publisher = null
}isrelationloaded false, author->publisher throws relationmissing if we dont ->load('publisher') before class Author {
#[Lazy]
public ?Publisher $publisher = null
}isrelationloaded false, author->publisher loads data class Author {
#[Eager]
public ?Publisher $publisher = null
}isrelationloaded true, author->publisher shows data loaded at the time of author fetch I guess thats how it should work? |
680c0fa to
16d248d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unset property so lazy loading works correctly for belongstoman, isRelationLoaded returns corect value and empty results are correctly set