Skip to content

fix(release): resolve in-toto attestation UUID in wait-for-chains - #378

Open
infernus01 wants to merge 1 commit into
tektoncd:mainfrom
infernus01:fix-rekor-uuid-intoto
Open

fix(release): resolve in-toto attestation UUID in wait-for-chains#378
infernus01 wants to merge 1 commit into
tektoncd:mainfrom
infernus01:fix-rekor-uuid-intoto

Conversation

@infernus01

Copy link
Copy Markdown
Member

Changes

Summary

Problem

The chains.tekton.dev/transparency annotation on the publish-images
TaskRun points at a hashedrekord Rekor entry. This entry contains a
bare signature with no .Attestation payload, so the release notes
verification commands (rekor-cli get --uuid ... | jq -r .Attestation)
return empty. Verified broken on: chains v0.28.1, chains v0.29.0,
pruner v0.4.0, pruner v0.4.1.

Fix

Instead of trusting the transparency annotation, the task now:

  1. Reads the IMAGES result from the publish-images TaskRun
  2. Searches the Rekor index for all entries matching the first
    image digest
  3. Selects the entry with body kind intoto
  4. Falls back to the annotation-based approach if not found

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind bug

  The wait-for-chains task extracts the Rekor UUID from the
  chains.tekton.dev/transparency annotation, which points at the
  per-image signature entry (kind hashedrekord). This entry has
  an empty Attestation field, so the verification commands in the
  release notes silently produce no output.

  Search the Rekor index by image digest instead and select the
  entry whose body kind is intoto — the SLSA attestation that
  lists published images as subjects. Fall back to the transparency
  annotation if the attestation entry cannot be found.

  Ported from tektoncd/pipeline#10363.

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2026
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from infernus01 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.28%. Comparing base (05bebae) to head (c40cd29).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   50.28%   50.28%           
=======================================
  Files          19       19           
  Lines        2118     2118           
=======================================
  Hits         1065     1065           
  Misses        921      921           
  Partials      132      132           
Flag Coverage Δ
unit-tests 50.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants