fix(build): fetch golangci-lint install.sh from main branch - #3928
Open
aqeelat wants to merge 1 commit into
Open
fix(build): fetch golangci-lint install.sh from main branch#3928aqeelat wants to merge 1 commit into
aqeelat wants to merge 1 commit into
Conversation
The Makefile fetched install.sh from the deprecated golangci-lint
master branch. That copy greps the checksums file with an unanchored
basename match, which since the v2.12.2 release also matches the new
.sbom.json sidecar entries. The resulting multi-line "want" hash never
equals the tarball hash, so make lint-go fails checksum verification
even though the download is intact.
The main branch anchors the lookup (grep "${BASENAME}$") and installs
v2.12.2 cleanly. Verified make lint-go end-to-end with the new URL.
Upstream: golangci/golangci-lint#6572
Signed-off-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
Assisted-by: GLM-5.2 (via opencode)
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
=======================================
Coverage 26.33% 26.33%
=======================================
Files 465 465
Lines 24951 24951
=======================================
Hits 6572 6572
Misses 17661 17661
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@aqeelat Thanks for the fix! |
waveywaves
approved these changes
Aug 18, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: waveywaves The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
make lint-gofails checksum verification when bootstrapping golangci-lint: the Makefile fetchesinstall.shfrom the deprecatedmasterbranch, whose checksum lookup uses an unanchoredgrep "${BASENAME}". Releases now ship SBOM sidecars (<tarball>.sbom.json), so the lookup matches two checksum lines and the comparison always fails — even though the downloaded tarball hash is correct.This switches the URL to the
mainbranch, where the lookup is anchored (grep "${BASENAME}$"). Verifiedmake lint-goend-to-end on darwin/arm64 with v2.12.2: downloads, verifies, lints clean.Upstream issue (closed, fixed on main): golangci/golangci-lint#6572
Submitter Checklist
These are criteria that every PR should meet, please check them off as you review them:
make test lintbefore submitting a PRNote:
make lint-gopasses end-to-end (this PR fixes its bootstrap).make lint-yamlcouldn't run locally (yamllint not installed); this change doesn't touch YAML linting. No functionality or user-facing behavior changed, so no tests/docs included.Release Notes