Skip to content

Cleanup/remove deprecate chains cmd#2769

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
adityavshinde:cleanup/remove-deprecate-chains-cmd
Mar 20, 2026
Merged

Cleanup/remove deprecate chains cmd#2769
tekton-robot merged 2 commits intotektoncd:mainfrom
adityavshinde:cleanup/remove-deprecate-chains-cmd

Conversation

@adityavshinde
Copy link
Contributor

Changes

fixes: #2751

  • Removed pkg/cmd/chain/chain.go
  • Removed pkg/cmd/chain/signature.go
  • Removed pkg/cmd/chain/payload.go
  • Removed docs/cmd/tkn_chain.md
  • Removed docs/cmd/tkn_chain_signature.md
  • Removed docs/cmd/tkn_chain_payload.md
  • Modified pkg/cmd/root.go
  • Modified pkg/cmd/testdata/TestPluginList.golden

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 15, 2026
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2026
@waveywaves
Copy link
Member

@adityavshinde the CI isn't green here

@waveywaves
Copy link
Member

cc @vdemeester

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2026
@anithapriyanatarajan
Copy link

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 19, 2026
@anithapriyanatarajan
Copy link

@pratap0007 @divyansh42 - could you help reviewing this PR. Thankyou

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityavshinde for the PR!
Changes look good! Can you please squash the commits into two? We can keep one commit for the chains cmd removal and another one for the OCI buckets-related changes.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
Run make generated

chore: run update-codegen.sh to fix CI
@adityavshinde adityavshinde force-pushed the cleanup/remove-deprecate-chains-cmd branch from 4c4f4a6 to fd853b7 Compare March 20, 2026 06:10
@adityavshinde
Copy link
Contributor Author

Thanks @adityavshinde for the PR! Changes look good! Can you please squash the commits into two? We can keep one commit for the chains cmd removal and another one for the OCI buckets-related changes.

Thank you @divyansh42 for reviewing. I have squashed the commits into 2 commits.

@waveywaves
Copy link
Member

Reviewing once before I put lgtm

Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 3d05ba3 into tektoncd:main Mar 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated chains command

5 participants