Skip to content

Conversation

@bernoullithedev
Copy link
Contributor

Updated the SettlementTransaciton interface by introducing the following enhancements:

  1. Added missing nested object types: Customer, SubAccount, and Authorization
  2. Used utility types (Omit) to tailor the nested types and exclude properties not returned in the settlement transaction response

Copy link
Owner

@tekpriest tekpriest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better to explicitly pick the fields we want to expose rather than omitting several, as Omit can unintentionally allow fields to slip through if the SubAccount type changes in the future. Using Pick (or a dedicated response type) makes the contract clearer, more secure, and easier to maintain.

bernoullithedev and others added 4 commits June 15, 2025 01:03
Co-authored-by: Asaju Enitan Michael <16443589+tekpriest@users.noreply.github.com>
Co-authored-by: Asaju Enitan Michael <16443589+tekpriest@users.noreply.github.com>
subaccount

Co-authored-by: Asaju Enitan Michael <16443589+tekpriest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants