Skip to content

fix(github.issue.welcome): grant issue read permission for PR history - #43

Merged
posquit0 merged 1 commit into
mainfrom
fix/welcome-issues-read-permission
Oct 13, 2026
Merged

posquit0 merged 1 commit into
mainfrom
fix/welcome-issues-read-permission

Conversation

@posquit0

@posquit0 posquit0 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

👋 Background

The PR welcome job fails with 403 Resource not accessible by integration when looking up the author's contribution history. It calls issues.listForRepo, which requires issues: read even when checking pull requests; the caller currently grants only pull-requests: write.

🔗 Related Issues

⚙️ Description

  • Grant issues: read to this repository's PR welcome job while retaining pull-requests: write for comments.
  • Correct the composite action and reusable workflow token descriptions and document the PR-only permissions example.
  • Keep the welcome action's behavior unchanged.

Validation: all 16 welcome tests passed; yamllint, jactionlint correctness checks, GitHub Actions/workflow schema validation, and git diff --check passed.


🚨 To Reviewers

Caller workflows must grant the permission; a reusable workflow cannot elevate the caller's token. The companion Terraform-template PR must also be deployed to update downstream callers. Rerunning the original failing workflow revision alone will not pick up the caller permission change.

@github-actions github-actions Bot added 💾 actions This issue or pull request is related to actions. 💾 workflows This issue or pull request is related to workflows. size/S Small size issue or PR. labels Oct 13, 2026
@posquit0 posquit0 closed this Oct 13, 2026
@posquit0 posquit0 reopened this Oct 13, 2026
@posquit0
posquit0 merged commit d617c5a into main Oct 13, 2026
10 checks passed
@posquit0
posquit0 deleted the fix/welcome-issues-read-permission branch October 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 actions This issue or pull request is related to actions. 💾 workflows This issue or pull request is related to workflows. size/S Small size issue or PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant