Repository navigation
fix(github.pr.claude-code)!: take the GitHub App Client ID as github_app_client_id - #38
Merged
Merged
Conversation
`actions/create-github-app-token@v3` deprecates `app-id` in favor of `client-id`, which also accepts the numeric App ID, so callers keep passing the same `github_app_id` secret.
👋 Welcome! Looks like this is your first pull request.Hey, thanks for your contribution! Please give us a bit of time to review it. 😄 Please check out our contributing guidelines. |
github-actions
Bot
added
💾 workflows
posquit0
marked this pull request as ready for review
October 11, 2026 15:36
GitHub Actions Integration
✅ All 1 passed. |
…_app_client_id` BREAKING CHANGE: the `github_app_id` secret is renamed to `github_app_client_id`. Pass the Client ID of the GitHub App.
posquit0
changed the title
client-idgithub_app_client_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Background
actions/create-github-app-token@v3deprecatesapp-idin favor ofclient-id, and GitHub recommends the Client ID as the JWT issuer. Upstream actionlint v1.7.12 rejectedclient-id, so this waited for the switch to jactionlint in #37.What changed
github.pr.claude-code: pass the GitHub App credentials asclient-idinstead ofapp-id.github_app_idsecret togithub_app_client_id. Callers must pass the App's Client ID (it starts withIv) under the new name.Notes
tedilabs/github-actions/.github/workflows/github.pr.claude-code.yamlwas found in the tedilabs repositories or in GitHub code search.datarize-infra/oktaanddeplanet/oktacall their own organizations'github-actionscopies, so they are not affected.client-idfirst and falls back toapp-id(core.getInput("client-id") || core.getInput("app-id")). GitHub accepts either the Client ID or the App ID as the JWT issuer and recommends the Client ID, so a numeric App ID passed under the new name still works.jactionlint --profile=correctnesspasses on every workflow in this repository, andyamllintpasses.pushrun onmainthat feat(github-actions.actionlint): lint with jactionlint #37 left (deprecatedapp-id).