Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| {:else if labels} | ||
| {#each seriesState.visibleSeries as s, i (s.key)} | ||
| <Labels {...getLabelsProps(s, i)} /> | ||
| <Labels {...getLabelsProps(s, i)} placement="smart" /> |
There was a problem hiding this comment.
placement="smart" should come before getLabelProps so it can be overridden (ex. Labels within points)
Note: where this is handled is changing within state-refactor branch/PR, which is going to cause a merge conflict. I might keep this PR open and manually merge into state-refactor once the dust settles there.
| } | ||
| } | ||
|
|
||
| function getDynamicTextProps( |
There was a problem hiding this comment.
Let's call this getSmartTextProps(), although I wonder if we could merge this into getTextProps() (instead of early returning in getTextProps(), capture the baseProps and then use them if placement === 'smart' or return as is if not.
Although not sure how much of baseProps we really need at first glance
2 participants
No description provided.