fix(desktop): declare background startup before macOS launches browser workers - #43
Merged
Merged
Conversation
techflag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser workers share the Desktop application bundle. macOS previously launched that bundle as foreground before JavaScript hid the worker, allowing Dock flicker. Declare LSUIElement in the packaged native plist, promote only the primary application to regular activation, and keep workers accessory. Packaging rejects missing native startup metadata. No extra application or runtime is introduced.
Validation: Desktop build/typecheck, 126 unit tests and 13 release checks passed. Primary foreground activation is covered in lifecycle tests. Packaged acceptance passed: 182 valid macOS startup observations all UIElement and none Foreground; hidden browser rendering and primary Foreground window entry both passed. DMG verification is finishing.