chore(node): update Node.js version to 24.18.1 - #10555
Conversation
PR Summary by QodoUpdate project Node.js baseline to 24.18.1 across CI, Docker, and workspace config
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
1. Dangling CircleCI job refs
|
|
|
||
| # ========== Docker Jobs ========== | ||
| docker_build_node_22: | ||
| docker_build_node_24: |
There was a problem hiding this comment.
1. Dangling circleci job refs 🐞 Bug ☼ Reliability
CircleCI workflow harmony_deploy_manual still invokes docker_build_node_22/docker_non_root_build_node_22/server_docker_build_node_22, but this PR renames those jobs to *_node_24, leaving the manual deploy workflow referencing undefined jobs and failing configuration validation/execution.
Agent Prompt
## Issue description
CircleCI jobs were renamed from `*_node_22` to `*_node_24`, but the `harmony_deploy_manual` workflow still references the old job names, which no longer exist.
## Issue Context
The renamed job definitions exist as `docker_build_node_24`, `docker_non_root_build_node_24`, and `server_docker_build_node_24`.
## Fix Focus Areas
- .circleci/config.yml[1636-1676]
- .circleci/config.yml[1202-1248]
## Implementation notes
- In `harmony_deploy_manual`, replace:
- `docker_build_node_22` -> `docker_build_node_24`
- `docker_non_root_build_node_22` -> `docker_non_root_build_node_24`
- `server_docker_build_node_22` -> `server_docker_build_node_24`
- Update `requires:` references accordingly (e.g., `server_docker_build_node_24` should require `docker_build_node_24`).
- Run CircleCI config validation after the change.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit aaaf52a |
Prettier incorrectly escapes JSX comment markers (\`/* */\` → \`\/* *\/\`) inside these two MDX files' code blocks, breaking the comment syntax. Excludes both files from prettier and fixes the existing bad escaping. Split out of the Node 24 branch (#10555), where it was an unrelated change picked up along the way.
Update Node.js version to 24.18.1 (latest Node 24 LTS) across the project. This ensures compatibility with the latest features and security patches.
Replaces #9933 (branch renamed from
chore/update-nodejs-24-6-0tochore/update-nodejs-24and version bumped from 24.13.0 to 24.18.1).