fix(docker): 修复源码镜像构建输入 - #497
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📝 WalkthroughWalkthroughDockerfile 的 Merge Risk: 🔵 Low · up to The PR restores Docker source builds that include all required root Go files, preventing undefined-symbol build failures. It is mergeable with owner awareness that the new contract test should be tightened to validate the active go-builder stage specifically, otherwise a future Dockerfile regression could escape detection. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches✨ Simplify code
Warning Some tools did not complete. Review the errors below. 🔧 golangci-lint (2.12.2)Error: can't load config: the Go language version (go1.26) used to build golangci-lint is lower than the targeted Go version (1.27.0) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (1)
internal/webui/container_contract_test.go-336-339 (1)
336-339: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win将断言限定到
go-builder阶段。当前断言搜索整个 Dockerfile,且不区分活动指令与注释。若
go-builder将来退化为COPY runtime.go ./,但其他阶段或注释中仍包含COPY *.go ./,该测试仍会通过。请先提取go-builder阶段,再匹配该阶段中的活动COPY *.go ./指令,并检查单文件 Go 源复制规则。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: QUIET
Plan: Pro Plus
Run ID: 1ac40c4d-b4da-4b25-88d7-9aa34a7a9796
📒 Files selected for processing (2)
Dockerfileinternal/webui/container_contract_test.go
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.
关联 Issue / Related Issue
无 / None
变更内容 / Change Content
main.go改为复制全部根目录 Go 源文件,修复新增runtime.go、service_*.go后的未定义符号错误。验证:
go test -count=1 -run TestDockerfileSourceBuildCopiesAllRootGoSources ./internal/webuiRELEASE_SMOKE_SKIP_SCAN=true .github/scripts/release-docker-smoke.shmake check自查清单 / Checklist
make check,或在说明中写明无法运行的原因和未验证范围。 / I ranmake check, or documented why it could not run and what remains unverified.Summary by CodeRabbit
改进
测试