Fixed check streams after restart. Stream will not try to create new …#21
Closed
Ruslan-Droid wants to merge 2 commits intotaskiq-python:masterfrom
Closed
Fixed check streams after restart. Stream will not try to create new …#21Ruslan-Droid wants to merge 2 commits intotaskiq-python:masterfrom
Ruslan-Droid wants to merge 2 commits intotaskiq-python:masterfrom
Conversation
danfimov
reviewed
Nov 17, 2025
| result_backend: "typing.Optional[AsyncResultBackend[_T]]" = None, | ||
| task_id_generator: typing.Optional[typing.Callable[[], str]] = None, | ||
| **connection_kwargs: typing.Any, | ||
| self, |
Member
There was a problem hiding this comment.
Please remove this unnessesary chanes with additional spaces
(I wonder why pre-commit hooks or CI checks didn't catch this...)
Removed extra spaces from the code
|
Hi @Ruslan-Droid and @danfimov , I've been running into a startup crash where add_stream fails with err_code=10058 ("stream name already in use with a different configuration") when the stream already exists and the configuration was enriched by my NATS production server. This PR seems to address that by adding an existence check before attempting to create the stream. Would you be willing to reopen or resubmit this fix? I'd be happy to contribute if that helps move it forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we start worker and code with broker that using streams it trying to create new stream every time. Added check if stream created. If not it will be created