Skip to content

fix(make): Send an empty JSON body on webhook detach - #54

Merged
deanzaka merged 1 commit into
masterfrom
fix/make-detach-empty-json-body
Nov 20, 2026
Merged

deanzaka merged 1 commit into
masterfrom
fix/make-detach-empty-json-body

Conversation

@deanzaka

Copy link
Copy Markdown
Contributor

Problem

When a user deleted a Make hook or scenario, the Taskade webhook stayed. Taskade then kept a subscription that nobody listens to.

Production logs for 2026-11-20 show that Make does run the detach step. Each detach DELETE /api/v2/webhooks/... got 400 in about 8 ms (req-1we at 09:48:02Z after an API delete, and a second one at 10:34:05Z after a delete in the Make UI). A "Make an API Call" probe with the same URL and Content-Type: application/json, but no body, also got [400] Bad Request. The same probe with a {} body got 200 and removed the webhook.

The URL encoding issue is a separate problem. Taskade fixed it in taskade/taskcade#34510, which is live in v6.316.0.

Fix

  • Add "body": {} to the 6 webhooks/*/detach.iml.jsonc files.
  • test/validate.mjs now fails a DELETE detach that has no body.

Test

  • node packages/make-app-taskade/test/validate.mjs: PASS. Without the webhook change it lists 6 failures.
  • I put the new detach code on the private Make app taskade-b3pzod (SDK API, all 6 webhooks).
  • End to end: I created hook 2879685 (New Projects), and Taskade Settings > API listed gdrl…. Then I deleted the hook in Make, and Taskade dropped gdrl… at once.

🤖 Generated with Claude Code

Make sends `Content-Type: application/json` on a detach DELETE. Taskade
answers 400 to a JSON request with an empty body, so the webhook stayed
in Taskade after a Make hook or scenario was deleted. Send `{}`.

The validator now fails a DELETE detach that has no body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@deanzaka
deanzaka merged commit 5ac5506 into master Nov 20, 2026
6 checks passed
@deanzaka
deanzaka deleted the fix/make-detach-empty-json-body branch November 20, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant