Repository navigation
fix(make): Send an empty JSON body on webhook detach - #54
Merged
Merged
Conversation
Make sends `Content-Type: application/json` on a detach DELETE. Taskade
answers 400 to a JSON request with an empty body, so the webhook stayed
in Taskade after a Make hook or scenario was deleted. Send `{}`.
The validator now fails a DELETE detach that has no body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user deleted a Make hook or scenario, the Taskade webhook stayed. Taskade then kept a subscription that nobody listens to.
Production logs for 2026-11-20 show that Make does run the detach step. Each detach
DELETE /api/v2/webhooks/...got 400 in about 8 ms (req-1weat 09:48:02Z after an API delete, and a second one at 10:34:05Z after a delete in the Make UI). A "Make an API Call" probe with the same URL andContent-Type: application/json, but no body, also got[400] Bad Request. The same probe with a{}body got 200 and removed the webhook.The URL encoding issue is a separate problem. Taskade fixed it in taskade/taskcade#34510, which is live in v6.316.0.
Fix
"body": {}to the 6webhooks/*/detach.iml.jsoncfiles.test/validate.mjsnow fails aDELETEdetach that has no body.Test
node packages/make-app-taskade/test/validate.mjs: PASS. Without the webhook change it lists 6 failures.taskade-b3pzod(SDK API, all 6 webhooks).gdrl…. Then I deleted the hook in Make, and Taskade droppedgdrl…at once.🤖 Generated with Claude Code