Skip to content

Add a foreground Claude provider for workflow roles - #1242

Open
taras wants to merge 1 commit into
mainfrom
codex/claude-workflow-role-runtime
Open

taras wants to merge 1 commit into
mainfrom
codex/claude-workflow-role-runtime

Conversation

@taras

@taras taras commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Why

Claude roles need to finish the work they start before they return a result. XMD needs an opt-in provider that carries the foreground controls through creation and reconnect while preserving ordinary ACP sessions.

What changes

  • The CLI registers claude-workflow-role alongside acpx. A document can select it with AgentProvider.
  • The profile sets CLAUDE_CODE_DISABLE_BACKGROUND_TASKS=1 and denies ScheduleWakeup and Monitor. ACPX forwards and persists those settings. A retained session with different or missing settings is refused before another prompt.
  • The ACP client spec documents the profile and retained-session contract. ACP and ACPX tests cover option propagation, cold reconnect, refusal and vendor integrity.

How it works

The CLI profile uses the existing adapter, session store and host identity coordination. ACPX carries its creation settings into the queue-owner runtime and restores them from the retained session record. The provider checks those settings before reusing the session.

Review guide

Start at packages/cli/src/agent-stack.ts, then trace ensureFromPrepared in packages/acp/src/provider.ts and the ACPX files listed in the vendor manifest. The provenance file records each patched forwarding and persistence point.

How to verify it

  • The standalone CLI resolves claude-workflow-role through AgentProvider. The same probe rejects an unregistered name.

  • The ACP provider, released runtime, CLI adapter and session coordinator, and ACPX vendor suites passed on the standalone runtime source. The run covered 21 tests and 150 steps.

  • deno task verify:clean passed for the standalone runtime commit.

  • Fable independently passed signed runtime head f36e3a11c88dd0896f80bbf970ee00f69376352a.

  • GitHub CI passed on the failed-job retry. The original Deno 20/22 shard hit the 120-second Implementation fixture timeout tracked in Implementation Markdown journey intermittently exceeds 120s in CI #1143. Both attempts tested the same runtime merge commit. First run · Passing retry

Scope

This PR is the runtime base of #1203. #1203 selects the provider in the example and carries the example's submission, review and end-to-end coverage. The model-alias work is tracked separately in #1239.

The original combined revision ce89bf1ae9b9ef03195c336ba745fdc10ca1c69c passed an independent Fable review. The split runtime and workflow have their own review receipts. The pilots remain pinned to the original combined revision.

Scope confirmation

  • The diff contains the runtime profile, ACPX plumbing, specification and runtime coverage.
  • The vendor provenance and integrity test identify the patched paths.
  • The reported checks and review match the published head.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant