Repository navigation
Order Sidekick recovery fixture reads after queued saves - #1241
Merged
Merged
Conversation
The R2 conversation fixture serialized provider saves but let loads read the disk store immediately. The fake ACP does not join its saves, so a later session resolution could miss the record an earlier turn had already queued and refuse the continuation; the cut then waited on a journal write that could no longer happen. A load now waits for the saves queued when it is asked. A cut phase also races its boundary against the message itself, so a message that settles first fails the phase with its answer instead of hanging. The owner stays suspended under the held write when the boundary wins. Removes the hosted R2q trial step and phase instrumentation used to diagnose #1231. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
taras
changed the title
taras
added
the
ci-main-red-fix
taras
marked this pull request as ready for review
November 11, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Sidekick recovery fixture queued the fake provider’s session saves but let disk reads run ahead. On Linux Bun, the first prompt could finish before its session file was visible to the second prompt. Sidekick correctly refused continuation. The fixture then waited for a journal write that could no longer happen. Captured Linux reproduction
What changes
The fixture waits for saves already queued when it reads a session. It also reports the message’s result if the message settles before the selected journal write. Once the cut is reached, the fixture observes the held operation and leaves cleanup to its owning scope.
How to verify it
Review and CI
Independent Fable review passed on
2893a6165b3311c095e8ae9329ccc751083357e3. Linux Bun 1.4.0 passed both original R2q cases, the cold-reopen control, and the new early-settlement regression. The labeled run's required aggregate, including composability, passed. Linux Bun shard · Required CICloses #1231.