Repository navigation
Overlap the Implementation workflow’s checkout reads - #1238
Merged
Merged
Conversation
This was referenced Nov 10, 2026
taras
marked this pull request as ready for review
November 11, 2026 03:59
Ticket.Checkout asked for its staged and unstaged changes one after the
other, although each read owns its own containment and private index and
neither depends on the other. A local Ticket.CheckoutReads value component
now starts both through the existing GitQuery API inside one Effection
all(), and Ticket.Checkout returns the same {head, clean, staged, unstaged}
value from it.
The new Deno suite holds every read until both have entered, which the
serial component cannot satisfy, and proves exact HEAD, both tracked
comparisons, untracked exclusion, fresh reads, an unchanged index, the
foreign-checkout refusal, and that a failed or halted pair settles only
after its sibling's cleanup.
Refs #1143
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ticket.Checkout overlapped its staged and unstaged reads through a TypeScript helper, which loader-free hosts such as the REPL cannot import, and whose two durable reads shared one coroutine, so a reopened REPL entry could diverge when they arrived in the other order. The component now runs two <Git.Changes> inside <All>/<Spawn>: each read gets its own child coroutine and record, and <All> joins their JSON in authored order. RGO6 reopens an unfinished entry with the reads held in each order and expects zero native reads; the checkout suite runs without a module loader and round-trips a Markdown-hostile path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
taras
force-pushed
the
codex/1143-overlap-checkout-reads
branch
from
November 11, 2026 03:59
a40e68b to
35dd4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Implementation fixture intermittently exceeds its 120-second deadline in CI (#1143). Its workflow repeatedly checks HEAD and tracked changes. The staged and unstaged reads were independent but ran in sequence.
What changes
Ticket.Checkoutruns its existing staged and unstaged Git reads in two Markdown<Spawn>branches under<All>. It joins their JSON in authored order and returns the existing HEAD, clean flag, and change pages. Each branch has its own durable coroutine, so an unfinished REPL entry can replay either completion order.What must stay true
How to verify it
Risks and limitations
The first draft introduced loader and replay regressions. Independent Fable review identified both, and CI reproduced the loader failure across Deno, Node, and Bun. Commit a40e68b replaces that helper with the Markdown composition and adds the discriminating replay regression.
The original causal requirement remains open. In a matched, instrumented Linux pair on one worker, the original serial carrier passed in 93.1 seconds and this correction passed in 90.7 seconds. Both made the same 92 checkout checks and 690 process calls. Time inside checkout fell from 8.95 to 8.30 seconds, a 0.65-second reduction. The baseline did not time out, and this single fixed-order comparison is subject to cache and instrumentation effects. It does not establish the historical timeout’s cause or a reliable remedy. This PR remains a draft while the original acceptance and delivery gates are unresolved.
Scope confirmation