Repository navigation
Compact REPL syntax discovery and include named structural references - #1229
Conversation
|
Spec review at
The preservation of ordinary bare Syntax/CLI/version-1 JSON, full identity checks, atomic unknown-name refusal and non-executing inspection is clear. Any additional policy choice should be recorded explicitly rather than inferred from current code. This feedback concerns the specification, not merge readiness. |
Address the maintainer review on #1229. Put generated placement in the composition contract. Separate bare presentation from named availability, including symbols middleware and fragment and root conformance. Specify index purpose derivation, fallback and bound, and link the shared named renderer. Evidence: syntax API, Syntax component, Evaluate, generated root, Sidekick controls and syntax CLI suites passed (50 tests, 320 steps).
|
Addressed the spec review in
The update changes only the two owning specs. The Syntax API/component, Evaluate, generated-root, Sidekick controls and syntax CLI suites passed (50 tests, 320 steps). The original Fable session could not resume. The existing independent Codex Astra reviewer passed the exact update under the recorded fallback policy. CI is tracked separately on the updated head. |
Address the maintainer review on #1229. Put generated placement in the composition contract. Separate bare presentation from named availability, including symbols middleware and fragment and root conformance. Specify index purpose derivation, fallback and bound, and link the shared named renderer. Evidence: syntax API, Syntax component, Evaluate, generated root, Sidekick controls and syntax CLI suites passed (50 tests, 320 steps).
4656495 to
796a345
Compare
Address the maintainer review on #1229. Put generated placement in the composition contract. Separate bare presentation from named availability, including symbols middleware and fragment and root conformance. Specify index purpose derivation, fallback and bound, and link the shared named renderer. Evidence: syntax API, Syntax component, Evaluate, generated root, Sidekick controls and syntax CLI suites passed (50 tests, 320 steps).
796a345 to
cb6853e
Compare
Address the maintainer review on #1229. Put generated placement in the composition contract. Separate bare presentation from named availability, including symbols middleware and fragment and root conformance. Specify index purpose derivation, fallback and bound, and link the shared named renderer. Evidence: syntax API, Syntax component, Evaluate, generated root, Sidekick controls and syntax CLI suites passed (50 tests, 320 steps).
cb6853e to
cbe5021
Compare
Why
Bare
REPL.Syntaxsends a full reference when Sidekick needs the available names first. A retained 85-name fixture produces 82,885 characters before the agent chooses what to inspect. Named inspection also refuses structural constructs that appear in the vocabulary.What changes
Before: discovery includes full contracts, and named inspection rejects engine constructs such as
Ifand installed parent/child syntax.After: bare
REPL.Syntaxreturns categories, exact names, short purposes and an actionable named lookup. The same fixture produces 6,105 characters with all 85 names retained. Named inspection returns complete ordinary, engine and installed structural references.Named engine availability also follows the real generated context. A narrowed
Evaluatefragment can describeIfas available and then execute it; installed constructs remain unavailable there. Root-only and parent/context rules remain qualified. BareSyntax, CLI Markdown and version-1 JSON keep their existing output.How it works
The compact index projects the existing vocabulary. Named references retain shared selection, rendering and full-identity checks. Generated fragment/root owners supply immutable engine-reference data through the existing internal
SyntaxReference.availableseam; only a named lookup uses it. Inspection shares the owner metadata projection and does not invoke installed handlers or broaden execution admission.Review guide
Start with
repl-profile.ts, the Syntax reference/selection/renderers and the generated fragment/root owners. Check lookup-local specialization, omitted versus empty data, middleware/read-once behavior, installed identity, fresh profile/include/Plugin selection and ordinary-component precedence. The named structural-reference amendment is explicitly accepted in #1178.How to verify it
50e26a423efdca71d42deaf57ddcc3a47a98a8b8.Risks and limitations
Current signed head:
50e26a423efdca71d42deaf57ddcc3a47a98a8b8; feature base:2bc5ef29b2966af27c7ba292dd42a759f6f69f79. Original Architect and original Planner feedback are PASS on the correction. Independent Codex Astra review is also PASS against all four acceptance clauses. The retained Fable session could not resume because its saved full model ID is absent from the offered catalog; its refusal and the normal fallback transition are preserved. Every corrected-head technical check passes after one unchanged-head retry of each recorded Deno DR6 and Delivery fallback failure. First and passing logs remain in #1200 and #1176; neither flake is claimed fixed. Main health remains the delivery blocker.The original Fable review on parent
7c3f0574is retained as CHANGES_REQUIRED. Correction 2 repairs its real narrowed-availability finding. An optional architecture diagnostic exhausted its response allowance without a canonical result; it remains failed and is not approval. The original Planner independently accepted the finite repair plan, followed by fresh corrected-source feedback. Two of the existing three source-correction slots are used; no allowance was reset.Earlier blocked results and first failures remain intact: broad selection stopped at registry DNS/cache metadata; build preparation later lacked the global Babel cache; compilation then encountered sandbox DNS while downloading Deno's runtime. Authorized preparation restored the exact frozen inputs, and the same original Codex Implementor completed the successful build/test. The incomplete broad run is not counted as passing evidence. No dependency version, runtime or Implementor session was substituted.
Parent CI's Node History final-selection failure is recorded in #1054 with its first log retained; no cause fix is claimed. Character measurements describe one fixture, with no token, latency or model-efficiency claim. Earlier Main-health failures remain recorded under #1224. Main has advanced to
c900ebfdthrough #1230; its new CI run is in progress, so current Main health is pending. This draft remains unmerged.Scope confirmation
Closes #1178.