Skip to content

Remove the automated PR reviewer and its implementation #1226

Closed

Description

@taras

Story

Pull requests no longer run or receive the automated PR Review report or comment-deletion suggestions. Remove its implementation and dedicated configuration rather than leaving a disabled package behind.

The maintainer explicitly requested disabling the automated reviewer and removing all its code. Recent reviews repeatedly flagged upstream patch context, lint directives and required vendor provenance comments. This retirement is an accepted product decision.

Scope

  • Remove .github/workflows/review.yml, packages/code-review-agent, and the review entrypoints, policy files and sensor configuration under .reviews.
  • Remove the companion manual repository-analysis entrypoints and workflow that consume the same retired package.
  • Remove workspace dependencies, lockfile entries, build/documentation registration, publication/release jobs, package inventory and references specific to the retired feature. Update the owning specifications and current documentation.
  • Remove tests solely for the retired reviewer. General plugin loading, compiled plugin assets, planning, testing-host, documentation and core execution coverage must survive with small purpose-built fixtures or existing supported plugins instead of depending on the deleted package.
  • Remove retired-only exemptions, task aliases and fixtures after tracing consumers. Keep shared functionality that still has a live consumer.

Acceptance

  • No active production/workspace/build/release/CI entrypoint references or runs the retired reviewer or its analysis command.
  • Prepared workspace dependency manifests and frozen locks agree, and builds/documentation checks do not import the deleted package.
  • Relevant plugin/documentation/compiled-distribution tests still exercise their existing general contracts; deletion does not silently remove that coverage.
  • Ordinary linting, required CI gates, and the adversarial implementation workflow's independent Fable/Astra reviews remain in place.
  • No new review framework or compatibility facade replaces the retired feature. Existing historical GitHub reviews and external credentials are left alone.

Verification

Trace all package and .reviews references, including workspace lockfiles, scripts/validate-documentation.ts, scripts/lib/compile.ts, publication workflows and affected tests. Run the smallest affected regressions and the repository's required dependency-change preparation/verification procedure. Required CI remains the delivery gate.

The shared source checkout contains unrelated local changes; use an isolated checkout. #1203 and its two prospective pilots remain separate and must not be modified or restarted for this removal.

Implementation and current delivery

Both hosted workflows are disabled (disabled_manually). The complete retirement is published in PR #1230, signed head 6e2dd3df3385e29bac309c6094c08889def9a5ec: 115 files, +309/-11,410 lines. The final independent Fable review is PASS. Normal setup, builds, affected tests, compiled/plugin and npm-package checks, lint/dead-code, typechecking and exact-head deno task verify:clean pass. The clean verification was run outside the sandbox so its unchanged child-process join could use ps; the earlier restricted failure is preserved. Full CI and current main health remain delivery gates. The PR is open and has not merged.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions