Repository navigation
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Restrictions link decoupled from Headplane discovery —
app/routes/settings/overview.tsxnow deriveshasOidcConfigfromheadscaleConfig.hasOIDCConfig()instead ofoidcContext, so the link no longer depends on Headplane's OIDC discovery reachingreadyafter a restart. - Consistent with the target page — the same
hasOIDCConfig()/getOIDCConfig()path gates the restrictions route's loader (which throws 501 when OIDC is unconfigured), so the link cannot surface a page that fails to load. - Regression tests —
tests/unit/settings/overview.test.tscovers the link for Headplane OIDC statespending/disabled/ready, plus hidden when Headscale has no OIDC config and when the config is not writable. TheoidcContextmock acts as a tripwire: reverting to the old condition would fail thepending/disabledcases. Ranpnpm vitest run --project unit tests/unit/settings/overview.test.ts— 5 passed. - Changelog — Fixes entry under
# Nextcloses #645.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #645.
The Authentication Restrictions link could disappear after restarting Headplane. This change checks Headscale's OIDC configuration instead of Headplane's discovery status, so the link stays visible.
Includes regression tests and a changelog entry.