Fix list-style-type documentation playground/code mismatch#2429
Open
Ahmed-aleryani wants to merge 4 commits intotailwindlabs:mainfrom
Open
Fix list-style-type documentation playground/code mismatch#2429Ahmed-aleryani wants to merge 4 commits intotailwindlabs:mainfrom
Ahmed-aleryani wants to merge 4 commits intotailwindlabs:mainfrom
Conversation
|
@Ahmed-aleryani is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
Update HTML code snippets to match the interactive playground examples: - Add missing 'list-inside' class to all three examples - Change <ol> to <ul> for list-decimal example to match playground Fixes tailwindlabs#2255
Ahmed-aleryani
force-pushed
the
fix-list-style-type-playground-mismatch
branch
from
ce87033 to
dcad6d4
Compare
Author
|
@thecrypticace Ready for review when you have a chance. Thanks! |
Author
|
@adamwathan Another low hanging fruit addressing an open issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistency between the interactive playground examples and the HTML code snippets in the list-style-type documentation.
Changes
list-insideclass to all three HTML code snippets (list-disc, list-decimal, list-none)<ol>to<ul>for the list-decimal example to match the playground implementationlist-insideclassIssue
Closes #2255
Testing
✅ Verified locally on development server
✅ Confirmed playground examples and code snippets now match exactly
✅ All three examples now correctly show
list-insideclass✅ Documentation renders correctly
Before
Code snippets showed:
<ul class="list-disc"><ol class="list-decimal"><ul class="list-none">But playground showed
list-insideon all examples.After
Code snippets now correctly show:
<ul class="list-inside list-disc"><ul class="list-inside list-decimal"><ul class="list-inside list-none">Matching the interactive playground examples.