Add @ianvs/prettier-plugin-sort-imports to html transform compat list#465
Open
zivenger wants to merge 1 commit into
Open
Add @ianvs/prettier-plugin-sort-imports to html transform compat list#465zivenger wants to merge 1 commit into
zivenger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this plugin together with
@ianvs/prettier-plugin-sort-imports, the two plugins conflict on.vuefiles depending on their order in the Prettier config.Following
tailwindlabs/prettier-plugin-tailwindcss's recommended placement (placing it last), the sort-imports plugin won't take effect on.vuefiles. Reversing the order causes this plugin to stop working instead.The root cause is that the
vueparser lives under thehtmltransform, whosecompatiblelist only includesprettier-plugin-organize-attributes— missing@ianvs/prettier-plugin-sort-imports. Thejstransform already has it, which is why.tsfiles work fine.This PR adds
@ianvs/prettier-plugin-sort-importsto thehtmltransform'scompatiblelist, resolving the compatibility issue for.vuefiles.