Skip to content

libtailscale: fix double close and stale device in multiTUN - #901

Open
gonzaarcr wants to merge 1 commit into
tailscale:mainfrom
gonzaarcr:fix-stale-connection-panic
Open

gonzaarcr wants to merge 1 commit into
tailscale:mainfrom
gonzaarcr:fix-stale-connection-panic

Conversation

@gonzaarcr

Copy link
Copy Markdown

Reopen from #886

09-21 13:35:56.361 D gojni: panic in multiTUN.run close of closed channel: goroutine 2 [running]:
runtime/debug.Stack()
/build/.cache/tailscale-go/src/runtime/debug/stack.go:26 +0x64
github.com/tailscale/tailscale-android/libtailscale.(*multiTUN).run.func1()
/build/tailscale-android/libtailscale/multitun.go:106 +0x3c
panic({0x7041e7e660?, 0x7042041950?})
/build/.cache/tailscale-go/src/runtime/panic.go:860 +0x12c
created by github.com/tailscale/tailscale-android/libtailscale.newTUNDevices in goroutine 40
/build/tailscale-android/libtailscale/multitun.go:99 +0x20c

09-21 13:35:56.379 E Go : panic: close of closed channel [recovered, repanicked]
09-21 13:35:56.384 F libc: Fatal signal 6 (SIGABRT), code -6 (SI_TKILL)
in tid 31023 (Thread-21), pid 30757 (m.tailscale.ipn)
09-21 13:35:58.345 I Zygote: Process 30757 exited due to signal 6 (Aborted)

Fixes tailscale/tailscale#21897

09-21 13:35:56.361 D gojni: panic in multiTUN.run close of closed channel: goroutine 2 [running]:
      runtime/debug.Stack()
          /build/.cache/tailscale-go/src/runtime/debug/stack.go:26 +0x64
      github.com/tailscale/tailscale-android/libtailscale.(*multiTUN).run.func1()
          /build/tailscale-android/libtailscale/multitun.go:106 +0x3c
      panic({0x7041e7e660?, 0x7042041950?})
          /build/.cache/tailscale-go/src/runtime/panic.go:860 +0x12c
      created by github.com/tailscale/tailscale-android/libtailscale.newTUNDevices in goroutine 40
          /build/tailscale-android/libtailscale/multitun.go:99 +0x20c

  09-21 13:35:56.379 E Go  : panic: close of closed channel [recovered, repanicked]
  09-21 13:35:56.384 F libc: Fatal signal 6 (SIGABRT), code -6 (SI_TKILL)
                             in tid 31023 (Thread-21), pid 30757 (m.tailscale.ipn)
  09-21 13:35:58.345 I Zygote: Process 30757 exited due to signal 6 (Aborted)

Fixes tailscale/tailscale#21897

Signed-off-by: Gonzalo <gonza.ar.cr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: Tailscale unrecoverable dying on Android

1 participant