Add a read_text implementation for async readers#856
Open
BitSyndicate1 wants to merge 2 commits intotafia:masterfrom
Open
Add a read_text implementation for async readers#856BitSyndicate1 wants to merge 2 commits intotafia:masterfrom
read_text implementation for async readers#856BitSyndicate1 wants to merge 2 commits intotafia:masterfrom
Conversation
Mingun
requested changes
Apr 22, 2025
Collaborator
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
Need to add tests to ensure that this will work as expected (especially check that trailing spaces are included in the text). Doc tests will be enougth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
read_text_into_asyncmethod for Readers which allows writing the content in between nested tags to an arbitraryAsyncWriter, analogous toReader::read_textandNsReader::read_textrespectively.