Updates dependencies, upgrades all functions to work with erlang 23, removes all streaming functions.#28
Open
Updates dependencies, upgrades all functions to work with erlang 23, removes all streaming functions.#28
Conversation
…removes all streaming functions.
… of the removal of streaming functions. Also adds erlang dependencies in extra applications.
|
we must upgrade to otp 25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the rabbit hole of upgrading to Erlang 24 to obtain better Dialyzer errors, I also had to upgrade this library - most of the
:cryptofunctions didn't exist anymore.I decided to drop all streaming related functions as they were not super clean, and never used from the ttapi-v2 codebase.