Repository navigation
Conversation
When find_package(Lua) fails, CMakeLists.txt falls back to LuaJIT, but the target only linked LUA_LIBRARIES, which is empty then, so the link failed. Link LUAJIT_LIBRARIES as well. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dktue
force-pushed
the
build/cmake-luajit
branch
from
November 16, 2026 10:58
9edcbd8 to
033776e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gain: with LuaJIT, a Germany build uses 9% less CPU and is 4% faster, with identical output. Planet (PMTiles, 32 threads): 1,703 → 1,682 s (−1.2%), user CPU −3.5%.
When
find_package(Lua)doesn't find Lua,CMakeLists.txtfalls back to LuaJIT,but only links
${LUA_LIBRARIES}, which is then empty, so the link fails. Thislinks
${LUAJIT_LIBRARIES}as well.With LuaJIT 2.1 (built with
cmake -DCMAKE_DISABLE_FIND_PACKAGE_Lua=TRUEandLUA_DIRpointing at it),a Germany build with
process-openmaptiles.luauses 9% less CPU and 4% lesswall time than with Lua 5.3. The output is the same: compared per tile, layer
and tags, every layer matches except
poi, which already differs between tworuns with the same binary.
🤖 Generated with Claude Code