Repository navigation
Conversation
dktue
force-pushed
the
fix/tile-write-errors
branch
from
November 16, 2026 10:59
efa0827 to
53e423c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any exception while writing tiles (SQLite error, disk full, bad_alloc, ...) escaped a thread-pool worker and called
std::terminate("terminate called recursively" when several threads hit it). The progress line usually overwrote the actual message.pool.join()(Error writing tile z12/2132/1493: ...), remaining batches are skipped, exit code 255. Same pattern as fix: clean error instead of std::terminate on missing nodes and Lua errors (#843) #947 for the .pbf reading phase..mbtiles: the finalCOMMITmoves from~MBTiles()(a throw there always terminates) tocloseForWriting(), and closing the tileset reports errors. Before: on a full disk, tilemaker printed "Filled the tileset with good things" and then aborted.saveTileuses aunique_lockso the DB mutex isn't left locked on error.Tested (Monaco, OpenMapTiles config):
terminate), patched printsError writing out.mbtiles: database or disk is fulland exits 255terminate(134), patchedError writing tile z12/2132/1493: injected test failure(255)Fixes #824 (the trigger there is unknown, but it will now be printed). May also explain #858.
🤖 Generated with Claude Code