Skip to content

Write PMTiles archives in binary mode #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Symmetricity wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Write PMTiles archives in binary mode #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pmtiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ PMTiles::~PMTiles() { }

void PMTiles::open(std::string &filename) {
std::cout << "Creating pmtiles at " << filename << std::endl;
outputStream.open(filename);
outputStream.open(filename, std::ios::out | std::ios::trunc | std::ios::binary);
// dummy header/root directory for now - we'll write it all later
char header[HEADER_ROOT] = "PMTiles";
outputStream.write(header, HEADER_ROOT);
Expand Down Expand Up @@ -122,7 +122,7 @@ void PMTiles::flushEntries(std::vector<pmtiles::entryv3> &rootEntries, std::vect
std::lock_guard<std::mutex> lock(fileMutex);
uint64_t location = outputStream.tellp();
uint64_t length = compressed.size();
outputStream << compressed;
outputStream.write(compressed.c_str(), compressed.size());

// append reference to the root directory
pmtiles::entryv3 rootEntry = pmtiles::entryv3(startId, location-leafStart, length, 0);
Expand Down Expand Up @@ -150,7 +150,7 @@ void PMTiles::saveTile(int zoom, int x, int y, std::string &data) {
std::lock_guard<std::mutex> lock(fileMutex);
// write to file
offset = TileOffset(static_cast<uint64_t>(outputStream.tellp()) - HEADER_ROOT, compressed.size());
outputStream << compressed;
outputStream.write(compressed.c_str(), compressed.size());
numTilesWritten++;
isNew = true;
}
Expand Down