build specifically with FreeRTOS 10.6.2#2
Open
SebKuzminsky wants to merge 1 commit intosysprogs:masterfrom
Open
build specifically with FreeRTOS 10.6.2#2SebKuzminsky wants to merge 1 commit intosysprogs:masterfrom
SebKuzminsky wants to merge 1 commit intosysprogs:masterfrom
Conversation
Before this small change, the PicoHTTPServer project would try to build against the development version of FreeRTOS (the tip of the master branch). At the current time this branch is in flux and PicoHTTPServer does not build. This commit specifies the exact version of FreeRTOS to build against as 10.6.2 (the most recent stable version), which I've verified works. A better solution might be to use FreeRTOS as a submodule, so that the PicoHTTPServer repo can explicitly control the FreeRTOS version, instead of relying on the build script to select one.
Author
|
Let me know if you'd prefer a PR that makes FreeRTOS a submodule of PicoHTTPServer. I think that would be a better long term solution. |
Author
|
For the record, this PR was prompted by the same error that @paulmreese fixed in #1, but this solution picks a specific release to build against and doesn't try to adapt PicoHTTPServer to the changing main development branch of FreeRTOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this small change, the PicoHTTPServer project would try to build against the development version of FreeRTOS (the tip of the master branch). At the current time this branch is in flux and PicoHTTPServer does not build.
This commit specifies the exact version of FreeRTOS to build against as 10.6.2 (the most recent stable version), which I've verified works.
A better solution might be to use FreeRTOS as a submodule, so that the PicoHTTPServer repo can explicitly control the FreeRTOS version, instead of relying on the build script to select one.