Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/test_conformance.py">
<violation number="1" location="tests/test_conformance.py:371">
P2: `KCONFIGLIB_OBSESSIVE_MIN_CONFIG` is still parsed but no longer affects defconfig collection, so enabling it no longer restores the previous cross-arch coverage. This is a behavior regression for the legacy env flag and silently reduces test coverage.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This limits default architecture set to representative archs (x86_64,
arm64, riscv, arm) instead of iterating all ~24. test_min_config is
further restricted to x86_64 only by default. Full coverage is
preserved via environment variables:
* KCONFIGLIB_OBSESSIVE=1 -- all architectures
* KCONFIGLIB_MIN_CONFIG=1 -- expand test_min_config to representative set
Parametrize test_defconfig, test_min_config, and test_sanity by (arch,
srcarch) so pytest reports per-arch timing and supports selective
re-runs (e.g. -k "test_defconfig[x86_64]").
Also replace shell("cp ...") with shutil.copyfile() in test_min_config
to eliminate shell injection risk from paths with spaces or special
characters.
4d93aaf to
7087ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This limits default architecture set to representative archs (x86_64, arm64, riscv, arm) instead of iterating all ~24. test_min_config is further restricted to x86_64 only by default. Full coverage is preserved via environment variables:
Parametrize test_defconfig, test_min_config, and test_sanity by (arch, srcarch) so pytest reports per-arch timing and supports selective re-runs (e.g. -k "test_defconfig[x86_64]").
Also replace shell("cp ...") with shutil.copyfile() in test_min_config to eliminate shell injection risk from paths with spaces or special characters.
Summary by cubic
Cuts conformance test CI time by default by running a small, representative arch set and parametrizing tests for per-arch reporting. Full coverage remains opt-in via env vars.
Refactors
Bug Fixes
Written for commit 7087ba1. Summary will update on new commits.