fix: wait for canary artifact delivery before verification - #548
Merged
Conversation
Ishaan Gangwani (ishaan1124)
requested a review
from Aayam Bansal (aayambansal)
as a code owner
September 7, 2026 09:41
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…delivery # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scientific release canaries could start verification when a remote computation had exited but its artifact delivery was still pending. A packaged Modal Matplotlib run reproduced this: computation, capture, and cleanup succeeded, while the canary failed before the captured artifacts became visible.
Keep waiting through pending delivery under the existing deadline before validating outputs. Preserve explicit cleanup and the compute tool's change-notification semantics.
Validation: deterministic regression exercises terminal execution with pending delivery, then completed delivery; targeted scientific capability tests, format and typecheck. A fresh exact-source packaged rehearsal and all five Modal checks are required before stable publication.