fix(desktop): render splash pages as UTF-8 - #445
Merged
Ishaan Gangwani (ishaan1124) merged 1 commit intoAug 30, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Aayam Bansal (aayambansal)
deleted the
codex/fix-desktop-splash-encoding
branch
September 1, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
All changed paths are covered by the desktop shell contract. The regression rejects the prior unqualified
data:text/html,form and pins all three UTF-8 documents.Pre-Landing Review
No issues found. Independent review confirmed the MIME charset fixes the exact
%E2%80%A6→…failure mode.Design Review
No design issues found; this preserves the existing splash layout and corrects text decoding only.
Verification
node --check frontend/desktop/src/main.mjsgit diff --checkRelease
No source version/changelog edit: this repository's signed publish workflow creates the patch release commit and changelog metadata after merge.