Skip to content

fix(desktop): render splash pages as UTF-8 - #445

Merged
Ishaan Gangwani (ishaan1124) merged 1 commit into
mainfrom
codex/fix-desktop-splash-encoding
Aug 30, 2026
Merged

fix(desktop): render splash pages as UTF-8#445
Ishaan Gangwani (ishaan1124) merged 1 commit into
mainfrom
codex/fix-desktop-splash-encoding

Conversation

@ishaan1124

Copy link
Copy Markdown
Member

Summary

  • declare UTF-8 on every inline Electron desktop document
  • prevent the splash ellipsis and Unicode startup errors from rendering as mojibake
  • add a regression contract covering all three inline pages

Test Coverage

All changed paths are covered by the desktop shell contract. The regression rejects the prior unqualified data:text/html, form and pins all three UTF-8 documents.

Pre-Landing Review

No issues found. Independent review confirmed the MIME charset fixes the exact %E2%80%A6… failure mode.

Design Review

No design issues found; this preserves the existing splash layout and corrects text decoding only.

Verification

  • 32 desktop installer/updater/shell tests pass
  • node --check frontend/desktop/src/main.mjs
  • scoped Prettier check
  • git diff --check

Release

No source version/changelog edit: this repository's signed publish workflow creates the patch release commit and changelog metadata after merge.

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openscience Ready Ready Preview Aug 30, 2026 7:48am

Request Review

@ishaan1124
Ishaan Gangwani (ishaan1124) merged commit d89cc21 into main Aug 30, 2026
18 checks passed
@aayambansal
Aayam Bansal (aayambansal) deleted the codex/fix-desktop-splash-encoding branch September 1, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant