Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
|
Can you also please fix the issue with the transition from Spending to Auto always showing when there are lightning channel the moment user opens the Receive Sheet?! Thx in advance 🙏🏻 |
Collaborator
Nvm I opened a new issue to be fixed in a separate PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #871
This PR:
IndexOutOfBoundsException) when returning the app to the foreground on the Receive screenDescription
When the app goes to the background, the Lightning node stops and channels become unavailable. On return, the AUTO tab is removed from visible tabs but
selectedTabstill references it, causing an index of -1 to be passed to the tab row — triggering the crash.The fix resets the selected tab when it's no longer in the visible tabs list and adds a defensive index clamp in the tab row component. Additionally, the Spending tab now returns an empty invoice when the node is not running, showing the QR placeholder loading state instead of a stale bolt11 invoice.
Preview
bg-qr-code.webm
QA Notes
Note: only happens when FG service is disabled