-
Notifications
You must be signed in to change notification settings - Fork 1
fix: compiler warnings and code patterns #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8519098 to
6473f3f
Compare
This comment has been minimized.
This comment has been minimized.
6473f3f to
07b4993
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c19b0d1 to
0008849
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jvsena42
reviewed
Jan 15, 2026
app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt
Outdated
Show resolved
Hide resolved
jvsena42
reviewed
Jan 15, 2026
This comment has been minimized.
This comment has been minimized.
Member
|
LGTM ✅ Most changes are just idiomatic, without big differences in the business logic Testing... |
jvsena42
approved these changes
Jan 16, 2026
Member
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- Migration
- CJIT
- Open channels
- Migrate
- Check channels after migration
- Perform transactions
- Boost transactions
- Time formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Part of PR stack together with:
Description
This PR:
classinstead ofdata classordata objectcontextto logs where it was missingtry/catchstatements torunCatchingEnvconstantsMainUiStateaggregate model with direct use of the separated node & wallet states exposed via wallet viewmodelcompose-stability-analyzerplugindetekt-baselineby either fixing or suppressing all lint warnings inlinegoogle-services.jsonfiles for each build flavor group: mainnetRelease for PROD and the STAG one for the restPreview
N/A
QA Notes
Regression Tests: