Twin: synonymdev/bitkit-ios#843
Refs:
Problem or use case
When a subscription renewal falls due, Bitkit opens the ordinary payment sheet titled "Subscription". It shows the amount and the creator's contact, but not which subscription is due. A payer with two subscriptions to the same creator, or two at the same price, cannot tell them apart before swiping.
The name is already available. The renewal's payment request carries the subscription's note (the name the creator sent with the proposal), and the Subscriptions list and detail screens already use it as the title. The sheet does not render it: the From and For summary added in #1336 and #1358 is limited to one-off requests (SendConfirmScreen.kt, isOneOffPaymentRequest is false when the payment is a subscription payment), so a renewal falls back to the plain layout.
Proposed solution
@aldertnl, could you design how the renewal sheet shows the subscription name?
Default I would build unless the design says otherwise: reuse the From and For summary of the one-off request sheet, with From = the creator and For = the subscription name. Please also cover:
- where the name sits when Show details is open
- truncation of long names (the note is capped at 256 characters)
- what shows when the creator sent no name (today the app falls back to "Subscription")
- whether the sheet title stays "Subscription" or the name moves into it
Out of scope: the first payment when accepting a proposal (the review-and-subscribe sheet already names the subscription).
Alternatives considered
- Put the name in the sheet title instead of a For row. It saves space but loses the label, and long names would need truncation in the header.
- Show the name only under Show details. It is the smallest change, but the swipe happens on the main view, so the name would be hidden when the payer decides.
Additional context
- iOS has the same behaviour: the renewal request carries the subscription note, and the confirm sheet shows a note only for one-off requests. Tracked in the twin issue.
- Figma for the one-off request sheet, which the renewal sheet would follow:
Twin: synonymdev/bitkit-ios#843
Refs:
Problem or use case
When a subscription renewal falls due, Bitkit opens the ordinary payment sheet titled "Subscription". It shows the amount and the creator's contact, but not which subscription is due. A payer with two subscriptions to the same creator, or two at the same price, cannot tell them apart before swiping.
The name is already available. The renewal's payment request carries the subscription's note (the name the creator sent with the proposal), and the Subscriptions list and detail screens already use it as the title. The sheet does not render it: the From and For summary added in #1336 and #1358 is limited to one-off requests (
SendConfirmScreen.kt,isOneOffPaymentRequestis false when the payment is a subscription payment), so a renewal falls back to the plain layout.Proposed solution
@aldertnl, could you design how the renewal sheet shows the subscription name?
Default I would build unless the design says otherwise: reuse the From and For summary of the one-off request sheet, with From = the creator and For = the subscription name. Please also cover:
Out of scope: the first payment when accepting a proposal (the review-and-subscribe sheet already names the subscription).
Alternatives considered
Additional context