Add failing fixture for a parent class that is not first in its file - #292
Open
SanderMuller wants to merge 1 commit into
Open
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing fixture only, no fix. Follow-up to #282.
SkipParentMethodWithReferenceAfterExceptionis a copy of the existingSkipParentMethodWithReference. The only difference is that its parent sits in a file where another class-like is declared first:The child gets
Use explicit return value over magic &reference, even though the parent enforces the reference. Move the exception below the abstract class and the suite is green again, so declaration order is the only variable.On the vendor point: the rule does analyse only code I own. The test analyses one file, the fixture. The
Source/file is never in the analysed paths.ReflectionParser::parseMethodReflection()still opens it to find the parent method, and readsfindFirstInstanceOf($stmts, ClassLike::class), which is the exception. So the file being read is not the file being analysed, and I don't control it when the parent comes from a dependency.Bundling an exception with its class is common in older packages, for example
iamcal/sql-parser.