Add 5 Doctrine + Symfony-config rules - #291
Merged
Merged
Conversation
…InDefinitionFetch, NoServiceSetterCall, NoAutoconfiguredServiceTag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 rules extracted from a real Symfony/Doctrine app.
Doctrine
#[ManyToOne/OneToMany/OneToOne/ManyToMany]association must useTarget::class, not a stringtargetEntity.#[ORM\Entity]or a public staticloadMetadata()) must not be areadonlyclass, since Doctrine hydrates via reflection without the constructor.Symfony / config closures
$container->getDefinition('Foo\Bar')should usegetDefinition(Foo\Bar::class)when the string is a real class (compiler passes); a plain service id is left alone.->call('setX', [service(...)])should be a#[Required]setter; only asetXxx()fed aservice()is reported (a container parameter or non-setter call stays).defaults()usesautoconfigure(), a->tag()that autoconfiguration already adds by interface (console.command,form.type,kernel.event_subscriber,security.voter,twig.extension,validator.constraint_validator) is redundant; only a tag with no attributes of its own is reported.Each rule is registered in the matching set (
doctrine-rules.neon,symfony-config-rules.neon,symfony-rules.neon), documented in the README, and covered by aRuleTestCasewith report + skip fixtures.Green locally: ECS, PHPStan, Rector, composer-dependency-analyser, neon-lint, full PHPUnit (378 tests).