[symfony] NoNullableServiceInConstructorRule: allow nullable in data-holder namespaces - #290
Merged
Merged
Conversation
…-holder namespaces (Event, DTO, Token, Exception, Helper, Form\Type, Badge, ...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
NoNullableServiceInConstructorRule(14.14).The rule flagged nullable constructor params in classes that are plainly data holders, not services - events, DTOs, tokens, exceptions, helpers, form types and security badges legitimately carry nullable values. Consumers had to silence those with per-path
ignoreErrors.This bakes the exclusion into the rule: a class whose namespace contains
\Entity\,\Event\,\DTO\,\Message\,\DAO\,\Token\,\Exception\,\Helper\,\ValueObject\,\Form\Type\or\Badge\is skipped whole. The existing skips (abstract class,Throwable/DateTimeInterface, same-typed sibling param, anonymous class) stay.Covered by a new skip fixture in an
Eventnamespace; the report + other skip fixtures are unchanged.Green locally: ECS, PHPStan, Rector, tests.