[symfony] Add PreferClassServiceReferenceRule for config closures - #289
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv/prefer-class-service-reference
branch
from
September 21, 2026 08:37
c35739b to
5043412
Compare
TomasVotruba
enabled auto-merge (squash)
September 21, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PreferClassServiceReferenceRule(Symfony PHP config closures), plus its two collectors.When a config closure points a string service id at a class:
then a
service('some.helper')reference names the very same service the class does. The rule asks forservice(SomeHelper::class)instead, so the reference carries the type. Once every reference names the class, the string alias nothing else asks for can be dropped.Implementation:
ClassTargetServiceAliasCollectorcollectsalias('id', X::class)pairs,ServiceStringReferenceCollectorcollectsservice('id')string references,CollectedDataNodeand reports each string reference an alias already covers with a class.A
service(X::class)reference and aservice('id')no alias covers are left alone.Registered in
config/symfony-config-rules.neon(rule + both collectors), covered by aRuleTestCasewith config-closure fixtures.Green locally: ECS, PHPStan, Rector, composer-dependency-analyser, neon-lint, tests.